Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mixed_attributes_style to style #12572

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

y21
Copy link
Member

@y21 y21 commented Mar 27, 2024

It currently is in suspicious. I wouldn't say that the linted code is "most likely wrong or useless"
[...]
😅 I would still argue that this doesn't belong in the suspicious group, but rather in the style group.

These are some good points made on zulip.


changelog: Move [mixed_attributes_style] to the style category

@rustbot
Copy link
Collaborator

rustbot commented Mar 27, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 27, 2024
@llogiq
Copy link
Contributor

llogiq commented Mar 27, 2024

Thank you!

@bors r+

@bors
Copy link
Contributor

bors commented Mar 27, 2024

📌 Commit 5b95e90 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 27, 2024

⌛ Testing commit 5b95e90 with merge 014230c...

@bors
Copy link
Contributor

bors commented Mar 27, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 014230c to master...

@bors bors merged commit 014230c into rust-lang:master Mar 27, 2024
5 checks passed
@flip1995 flip1995 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2024
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Apr 25, 2024
@flip1995
Copy link
Member

rust-lang/rust#124369

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2024
…ulacrum

[beta] Clippy backport

r? `@Mark-Simulacrum`

Backports:

- rust-lang/rust-clippy#12486
- rust-lang/rust-clippy#12572
- rust-lang/rust-clippy#12508
- rust-lang/rust-clippy#12617

The first one is a bit bigger as usual for a backport. But it fixes a major issue with this lint that we overlooked. So I think this is worth it. After that was merged into nightly, there were no new issues opened about this lint, so IMO this is safe to backport to `beta` and put into stable.
@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants