Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for implied_bounds_in_impls in more positions #12308

Merged
merged 2 commits into from
Feb 25, 2024

Conversation

y21
Copy link
Member

@y21 y21 commented Feb 17, 2024

With this, we lint impl Trait implied bounds in more positions:

  • Type alias impl trait
  • Associated type position impl trait
  • Argument position impl trait
    • these are not opaque types, but instead are desugared to where clauses, so we need extra logic for finding them (check_generics), however the rest of the logic is the same

Before this, we'd only lint RPIT impl Traits.
"Hide whitespaces" and reviewing commits individually might make this easier

changelog: [implied_bounds_in_impls]: start linting implied bounds in APIT, ATPIT, TAIT

@rustbot
Copy link
Collaborator

rustbot commented Feb 17, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 17, 2024
@bors
Copy link
Contributor

bors commented Feb 19, 2024

☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts.

@xFrednet
Copy link
Member

That's a smart refactoring, I like the change! :D

You can r=me once you've rebased.

@y21 y21 force-pushed the more_implied_bounds branch from e4f800c to bbfe1c1 Compare February 25, 2024 22:12
@y21
Copy link
Member Author

y21 commented Feb 25, 2024

Rebased. Just had to re-bless the test since the $DIR was replaced with the actual directory path at some point
@bors r=xFrednet

@bors
Copy link
Contributor

bors commented Feb 25, 2024

📌 Commit bbfe1c1 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 25, 2024

⌛ Testing commit bbfe1c1 with merge aa2c94e...

@bors
Copy link
Contributor

bors commented Feb 25, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing aa2c94e to master...

@bors bors merged commit aa2c94e into rust-lang:master Feb 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants