fix: documentation of blocks_in_conditions lint
#12296
Conversation
Updated documentation + example of `blocks_in_conditions` lint, which has been updated recently to include `match` statements as well.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @xFrednet (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
the
S-waiting-on-review
|
Welcome to Clippy 👋 This version looks good to me, thank you for the update :D @bors r+ |
fix: documentation of `blocks_in_conditions` lint Updated documentation + example of `blocks_in_conditions` lint, which has been updated recently to include `match` statements as well. changelog: none
|
The CI failed, as the code examples need to be valid code. You can use leading match { something() } {
// ...
# _ => {}
} |
|
💔 Test failed - checks-action_test |
Example in blocks_in_conditions lint didn't compile.
|
Fixed it! |
|
Nice, thank you! @bors r+ |
fix: documentation of `blocks_in_conditions` lint Updated documentation + example of `blocks_in_conditions` lint, which has been updated recently to include `match` statements as well. changelog: none
|
💔 Test failed - checks-action_test |
|
The failed test doesn't seem to have anything to do with this PR? |
|
No it's not, the MacOS runners are currently flaky for some reason -.-. Retrying one or two times, usually helps. So here we go: @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Updated documentation + example of
blocks_in_conditionslint, which has been updated recently to includematchstatements as well.changelog: none