Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint incompatible_msrv in test code #12261

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Feb 10, 2024

fixes #12257

changelog: incompatible_msrv: Don't lint in test code

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2024

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Feb 10, 2024
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@dswij
Copy link
Member

dswij commented Feb 11, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 11, 2024

📌 Commit 9012d55 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 11, 2024

⌛ Testing commit 9012d55 with merge d29f2ee...

@bors
Copy link
Collaborator

bors commented Feb 11, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing d29f2ee to master...

@bors bors merged commit d29f2ee into rust-lang:master Feb 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_msrv false positive: tests
4 participants