Fix issue 11223: add check for identical guards in lint match_same_arms
#12059
+87
−47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11223
In the current
match_same_arms
implementation, if arms have guards, they are considered different. This commit adds equality checking for guards: arms are now considered equivalent only when they either both have no guards or their guards are identical.The portion responsible for checking guard equality is refactored to reuse the existing code for checking body equality. This is abstracted into a function called
check_eq_with_pat
. To optimize performance,check_same_guard
andcheck_same_body
here use closures for lazy evaluation, ensuring that the calculation is only performed when!(backwards_blocking_idxs...)
is true.changelog: [
match_same_arms
]: Add check for identical guards