-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not lint assertions_on_constants
for const _: () = assert!(expr)
#11966
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) soon. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
Thank you. @bors r+ |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This fixed the simple case of |
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de.
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de.
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de.
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de.
Fixes #8159
changelog: Fix
const _: () = assert!(expr)
false positive onassertions_on_constants
lint