Skip to content

Conversation

@kpreid
Copy link
Contributor

@kpreid kpreid commented Nov 16, 2023

Fixes typos and markup errors, and also makes the examples more realistic by hiding the ;s so as not to visibly be discarding the computed value. Affected lints:

  • redundant_as_str
  • unnecessary_map_on_constructor

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 16, 2023
@bors
Copy link
Contributor

bors commented Nov 17, 2023

☔ The latest upstream changes (presumably #11828) made this pull request unmergeable. Please resolve the merge conflicts.

Also make the examples more realistic by hiding the `;`s so as not to
visibly be discarding the computed value.
@kpreid
Copy link
Contributor Author

kpreid commented Nov 17, 2023

The original typo was fixed by the other PR but this PR still contains other improvements. Rebased.

@Alexendoo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 18, 2023

📌 Commit b3f4a90 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 18, 2023

⌛ Testing commit b3f4a90 with merge 6eb935a...

@bors
Copy link
Contributor

bors commented Nov 18, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 6eb935a to master...

@bors bors merged commit 6eb935a into rust-lang:master Nov 18, 2023
@kpreid kpreid deleted the typo branch November 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants