Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #11610 about mutable usage of argument in async function for the needless_pass_by_ref_mut lint #11622

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 6, 2023

Fixes #11610.

This was already fixed. I simply added a regression test.

changelog: Add regression test for #11610 about mutable usage of argument in async function for the needless_pass_by_ref_mut lint

…nt in async function for the `needless_pass_by_ref_mut` lint
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2023
@GuillaumeGomez
Copy link
Member Author

r? @Centri3

@rustbot rustbot assigned Centri3 and unassigned llogiq Oct 6, 2023
@GuillaumeGomez
Copy link
Member Author

Seems like Centri3 is busy so I was recommended another reviewer.

r? @blyxyas

@rustbot rustbot assigned blyxyas and unassigned Centri3 Oct 17, 2023
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks ❤️ (=^・^=)

@blyxyas
Copy link
Member

blyxyas commented Oct 17, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 17, 2023

📌 Commit ddd1564 has been approved by blyxyas

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 17, 2023

⌛ Testing commit ddd1564 with merge 2640d5c...

@bors
Copy link
Collaborator

bors commented Oct 17, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas
Pushing 2640d5c to master...

@bors bors merged commit 2640d5c into rust-lang:master Oct 17, 2023
5 checks passed
@GuillaumeGomez GuillaumeGomez deleted the needless_pass_by_ref_mut-regression-test-11610 branch October 17, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP with needless_pass_by_ref_mut, async function and closures
6 participants