Some housekeeping on lint descriptions #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
birkenfeld
force-pushed
the
housekeeping
branch
from
68ffef7 to
9ffb366
Compare
birkenfeld
force-pushed
the
housekeeping
branch
from
9ffb366 to
9a22140
Compare
| /// **Example:** | ||
| /// ```rust | ||
| /// if a && true // should be: if a | ||
| /// if !(a == b) // should be: if a != b |
There was a problem hiding this comment.
Thanks, pushed a fix.
|
I can't review the python commit, but the rest lgtm after some nits |
|
The py also looks good. I especially like the reduction of duplicate code. |
|
For some definition of “some” 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make lint doc related things nicer, more consistent.