Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

Fixes #11185.

cc @Centri3

changelog: Emit note if function is behind a cfg for NEEDLESS_PASS_BY_REF_MUT lint.

@rustbot
Copy link
Collaborator

rustbot commented Jul 25, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 25, 2023
@GuillaumeGomez
Copy link
Member Author

Updated.

@llogiq
Copy link
Contributor

llogiq commented Jul 25, 2023

Looks good to me. Good job on the test updates, too!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 25, 2023

📌 Commit 1c9772c has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 25, 2023

⌛ Testing commit 1c9772c with merge 2153c0f...

@bors
Copy link
Contributor

bors commented Jul 25, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 2153c0f to master...

@bors bors merged commit 2153c0f into rust-lang:master Jul 25, 2023
@GuillaumeGomez GuillaumeGomez deleted the needless-ref-mut-cfg branch July 25, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

needless_pass_by_ref_mut should not trigger for cfg-gated mod/fn

5 participants