Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lint [string_lit_chars_any] #11052

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 30, 2023

Closes #10389

This lint can probably be deprecated if/when rustc optimizes .chars().any(...).

changelog: New lint [string_lit_chars_any]

@rustbot
Copy link
Collaborator

rustbot commented Jun 30, 2023

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 30, 2023
@bors
Copy link
Contributor

bors commented Jul 1, 2023

☔ The latest upstream changes (presumably #11012) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the string_lit_chars_any branch from ab1ba47 to 0b2a9dd Compare July 2, 2023 16:21
@bors
Copy link
Contributor

bors commented Jul 5, 2023

☔ The latest upstream changes (presumably #10970) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the string_lit_chars_any branch 2 times, most recently from e27e74e to b62c879 Compare July 17, 2023 06:39
@bors
Copy link
Contributor

bors commented Jul 17, 2023

☔ The latest upstream changes (presumably #11116) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the string_lit_chars_any branch from b62c879 to 217485e Compare July 19, 2023 05:26
@Centri3 Centri3 force-pushed the string_lit_chars_any branch from 217485e to 9d08502 Compare July 19, 2023 05:38
@Jarcho
Copy link
Contributor

Jarcho commented Jul 19, 2023

Looks good now. Thank you. @bors r+

@bors
Copy link
Contributor

bors commented Jul 19, 2023

📌 Commit 9d08502 has been approved by Jarcho

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 19, 2023

⌛ Testing commit 9d08502 with merge ec57155...

@bors
Copy link
Contributor

bors commented Jul 19, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing ec57155 to master...

@bors bors merged commit ec57155 into rust-lang:master Jul 19, 2023
@Centri3 Centri3 deleted the string_lit_chars_any branch July 19, 2023 07:08
@bors bors mentioned this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restrict: str_literal.chars().any(|x| x == c) affects performance negatively
4 participants