Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for fully qualified paths in unnecessary_cast #10971

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Check for fully qualified paths in unnecessary_cast #10971

merged 2 commits into from
Jul 20, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 17, 2023

Noticed this doesn't pick up ::std::primitive::u32 or the sort, now it does
changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

r? @dswij

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 17, 2023
dswij
dswij reviewed Jun 27, 2023
View reviewed changes
clippy_lints/src/casts/unnecessary_cast.rs Outdated Show resolved Hide resolved
clippy_lints/src/casts/unnecessary_cast.rs Outdated Show resolved Hide resolved
@Centri3 Centri3 force-pushed the unnecessary_cast_fully_qual_fix branch from 7f396e6 to 33cd266 Compare June 29, 2023 09:30
@bors
Copy link
Contributor

bors commented Jul 19, 2023

☔ The latest upstream changes (presumably #11046) made this pull request unmergeable. Please resolve the merge conflicts.

@Centri3 Centri3 force-pushed the unnecessary_cast_fully_qual_fix branch 2 times, most recently from 63d31dc to e02f7cd Compare July 19, 2023 10:25
dswij
dswij reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, and I think it's good to merge afterward

clippy_lints/src/casts/unnecessary_cast.rs Show resolved Hide resolved
@Centri3 Centri3 force-pushed the unnecessary_cast_fully_qual_fix branch from e02f7cd to c450e47 Compare July 20, 2023 08:09
@Centri3 Centri3 force-pushed the unnecessary_cast_fully_qual_fix branch from c450e47 to 15b68c2 Compare July 20, 2023 08:11
dswij
dswij approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dswij
Copy link
Member

dswij commented Jul 20, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jul 20, 2023

📌 Commit 15b68c2 has been approved by dswij

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 20, 2023

⌛ Testing commit 15b68c2 with merge fbe292e...

@bors
Copy link
Contributor

bors commented Jul 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing fbe292e to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jul 20, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: dswij
Pushing fbe292e to master...

@bors bors merged commit fbe292e into rust-lang:master Jul 20, 2023
@Centri3 Centri3 deleted the unnecessary_cast_fully_qual_fix branch July 20, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij approved these changes

Assignees

@dswij dswij

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Centri3 @rustbot @bors @dswij