Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix useless_vec suggestion in for _ in vec![..] #10909

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

Alexendoo
Copy link
Member

@Alexendoo Alexendoo commented Jun 8, 2023

Fixes rust-lang/rust#111034
Fixes #2256

changelog: [useless_vec]: Fix suggestion in for _ in vec![..]

@rustbot
Copy link
Collaborator

rustbot commented Jun 8, 2023

r? @llogiq

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 8, 2023
@bors
Copy link
Contributor

bors commented Jun 8, 2023

📌 Commit f0f5d7e has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 8, 2023

⌛ Testing commit f0f5d7e with merge 9065cd9...

bors added a commit that referenced this pull request Jun 8, 2023
Fix `useless_vec` suggestion in `for _ in vec![..]`

Fixes rust-lang/rust#111034

changelog: [`useless_vec`]: Fix suggestion in `for _ in vec![..]`
@bors
Copy link
Contributor

bors commented Jun 8, 2023

💔 Test failed - checks-action_dev_test

@Alexendoo Alexendoo force-pushed the useless-for-in-vec branch from f0f5d7e to b05126c Compare June 8, 2023 17:21
@llogiq
Copy link
Contributor

llogiq commented Jun 8, 2023

You should cargo dev fmt your code and either call above and below somewhere in your test or #[allow(unused)].

@Alexendoo Alexendoo force-pushed the useless-for-in-vec branch from b05126c to d132ff5 Compare June 8, 2023 17:25
@Alexendoo Alexendoo force-pushed the useless-for-in-vec branch from d132ff5 to 96697d2 Compare June 8, 2023 17:27
@llogiq
Copy link
Contributor

llogiq commented Jun 8, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 8, 2023

📌 Commit 96697d2 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 8, 2023

⌛ Testing commit 96697d2 with merge e2c655b...

@bors
Copy link
Contributor

bors commented Jun 8, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing e2c655b to master...

@bors bors merged commit e2c655b into rust-lang:master Jun 8, 2023
@Alexendoo Alexendoo deleted the useless-for-in-vec branch June 8, 2023 18:26
@Alexendoo
Copy link
Member Author

Fourth time was the charm 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clippy applies wrong fix for useless_vec for Edition 2021 useless_vec doesn't suggest a necessary &
4 participants