Clippy Book Chapter Updates Reborn: Emitting lints #10598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #10605) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
reviewed
Apr 16, 2023
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
All my comments here are about making this a bit slimmer mixed with a lot of nitpicking.
Contributor
|
☔ The latest upstream changes (presumably #10653) made this pull request unmergeable. Please resolve the merge conflicts. |
blyxyas
force-pushed
the
book-emit_lints
branch
from
b313398 to
b8f468d
Compare
blyxyas
force-pushed
the
book-emit_lints
branch
from
bfee2dd to
f76615a
Compare
Member
Author
|
The new commit should fix all the issues from the reviews. |
flip1995
approved these changes
Aug 18, 2023
bors
added a commit
that referenced
this pull request
Sep 2, 2023
Clippy Book Chapter Updates Reborn: Writing tests This PR adds a new chapter to the book: "Writing tests". The changes have been mainly done from reviews from #9426 and some minor re-writes. ## Notes - We still need to check that the `git status`es are correct, as `cargo dev new_lint` changed a lot since 2022. - Requires #10598: Link to "Emitting Lints" where I flagged with `FIXME:`. - To talk about the whole project, please use the tracking issue for the project #10597 (It also contains a timeline, discussions and more information) changelog: Add a new "Writing tests" chapter to the book r? `@flip1995`
blyxyas
force-pushed
the
book-emit_lints
branch
from
7f5cdc8 to
a26937f
Compare
Member
Author
|
@bors r=flip1995 |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Sep 2, 2023
Clippy Book Chapter Updates Reborn: Emitting lints The PR adds a new chapter to the book: "Emitting lints". This time it changed a lot from the old source file. ## Notes - For discussion about the whole project, please use the tracking issue for the project #10597 (It also contains a timeline, discussions, and more information) changelog: Add a new "Emitting lints" chapter to the book r? `@flip1995`
Member
Author
|
@bors r- |
Member
Author
|
@bors r=flip1995 |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds a new chapter to the book: "Emitting lints". This time it changed a lot from the old source file.
Notes
changelog: Add a new "Emitting lints" chapter to the book
r? @flip1995