invalid_regex: Show full error when string value doesn't match source
#10231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @llogiq (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Alexendoo
commented
Jan 26, 2023
Comment on lines
+97
to
+106
| error: regex parse error: | ||
| /b/c | ||
| ^^ | ||
| error: unrecognized escape sequence | ||
| --> $DIR/regex.rs:40:42 | ||
| | | ||
| LL | let escaped_string_span = Regex::new("/b/c"); | ||
| | ^^^^^^^^ | ||
| | | ||
| = help: consider using a raw string literal: `r".."` |
There was a problem hiding this comment.
compiletest is doing its windows path normalisation thing, it looks like this normally:
error: regex parse error:
\b\c
^^
error: unrecognized escape sequence
--> ../t.rs:6:42
|
6 | let escaped_string_span = Regex::new("\\b\\c");
| ^^^^^^^^
|
= help: consider using a raw string literal: `r".."`
llogiq
reviewed
Jan 29, 2023
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
invalid_regex]: Show full error when parsing non-literals or regular strings containing escape sequencesFixes #4170, the escape sequence there causes the span to be incorrect which will have caused most of the confusion