ICE with wasm target

[cmyr]

Just updated rustc/clippy and have a crash in CI, running:

cargo clippy --manifest-path=druid/Cargo.toml --all-targets --features=image,im --target wasm32-unknown-unknown

against linebender/druid@ac936c2

I do not see this crash against the native target (I'm running macOS 10.14.6)

let me know if I can be more helpful.

Meta

• clippy 0.0.212 (18bf6b4f0 2020-10-07)
• rustc -Vv:

rustc 1.47.0 (18bf6b4f0 2020-10-07)
binary: rustc
commit-hash: 18bf6b4f01a6feaf7259ba7cdae58031af1b7b39
commit-date: 2020-10-07
host: x86_64-apple-darwin
release: 1.47.0
LLVM version: 11.0

Error output

error: internal compiler error: unexpected panic

Backtrace

thread 'rustc' panicked at 'index out of bounds: the len is 1 but the index is 1', s
rc/tools/clippy/clippy_lints/src/repeat_once.rs:44:93
stack backtrace:
 0: _rust_begin_unwind
 1: core::panicking::panic_fmt
 2: core::panicking::panic_bounds_check
 3: <clippy_lints::repeat_once::RepeatOnce as rustc_lint::passes::LateLintPass>::c
heck_expr
 4: <rustc_lint::late::LateLintPassObjects as rustc_lint::passes::LateLintPass>::c
heck_expr
 5: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::v
isit_expr
 6: rustc_hir::intravisit::walk_expr
 7: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::v
isit_expr
 8: rustc_hir::intravisit::walk_expr
 9: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::v
isit_expr
10: <rustc_lint::late::LateContextAndPass<T> as rustc_hir::intravisit::Visitor>::v
isit_nested_body
11: rustc_hir::intravisit::walk_item
12: rustc_hir::intravisit::Visitor::visit_nested_item
13: rustc_hir::intravisit::walk_item
14: rustc_hir::intravisit::Visitor::visit_nested_item
15: rustc_hir::intravisit::walk_item
16: rustc_hir::intravisit::Visitor::visit_nested_item
17: rustc_hir::intravisit::walk_item
18: rustc_hir::intravisit::Visitor::visit_nested_item
19: rustc_hir::intravisit::walk_crate
20: rustc_lint::late::late_lint_pass_crate
21: rustc_lint::late::late_lint_crate
22: rustc_data_structures::sync::join
23: rustc_session::utils::<impl rustc_session::session::Session>::time
24: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_onc
e
25: rustc_session::utils::<impl rustc_session::session::Session>::time
26: rustc_interface::passes::analysis
27: rustc_middle::ty::query::<impl rustc_query_system::query::config::QueryAccesso
rs<rustc_middle::ty::context::TyCtxt> for rustc_middle::ty::query::queries::analysis
>::compute
28: rustc_middle::dep_graph::<impl rustc_query_system::dep_graph::DepKind for rust
c_middle::dep_graph::dep_node::DepKind>::with_deps
29: rustc_query_system::dep_graph::graph::DepGraph<K>::with_task_impl
30: rustc_data_structures::stack::ensure_sufficient_stack
31: rustc_query_system::query::plumbing::get_query_impl
32: rustc_interface::queries::<impl rustc_interface::interface::Compiler>::enter
33: rustc_span::with_source_map
34: rustc_interface::interface::create_compiler_and_run
35: scoped_tls::ScopedKey<T>::set
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtra
ce.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

[ebroto]

 3: <clippy_lints::repeat_once::RepeatOnce as rustc_lint::passes::LateLintPass>::c
heck_expr

I suspect this may be fixed by #5948. Could you try with beta 1.48?

[cmyr]

This works for me with the beta.

cargo +beta -Vv:

cargo 1.48.0-beta (75615f8e6 2020-09-29)
release: 1.48.0
commit-hash: 75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2
commit-date: 2020-09-29

[ebroto]

This works for me with the beta.

Thanks for testing it. I'm gonna go ahead and close this as solved.