Disabling of the precedence lint is incorrect for chained expressions #5924
Labels
C-bug
Category: Clippy is not doing the correct thing
Comments
ghost
mentioned this issue
bors
added a commit
that referenced
this issue
Aug 20, 2020
Fix false positive in `PRECEDENCE` lint Extend the lint to handle chains of methods combined with unary negation. Closes #5924 changelog: Fix false negative in `PRECEDENCE` lint
hegza
pushed a commit
to hegza/rust-clippy
that referenced
this issue
Aug 25, 2020
Extend the lint to handle chains of methods combined with unary negation. Closes rust-lang#5924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #4892 it was requested that the precedence lint should be disabled for odd functions, but it looks like the fix was implemented incorrectly, as seen in this URLO post. As an example,
-1.0_f64.cos().sin()does not trigger the lint, even thoughcosis not an odd function. Same goes for-1.0_f64.sin().cos()and even for-1.0_f64.cos().cos().Clippy version: 0.0.212 (2020-08-17 792c645)
The text was updated successfully, but these errors were encountered: