Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useless_attribute should not warn unreachable_pub #4106

Closed
taiki-e opened this issue May 17, 2019 · 0 comments · Fixed by #4107
Closed

useless_attribute should not warn unreachable_pub #4106

taiki-e opened this issue May 17, 2019 · 0 comments · Fixed by #4107

Comments

@taiki-e
Copy link
Member

taiki-e commented May 17, 2019

unreachable_pub can apply to use.

#![warn(unreachable_pub)]
#![warn(clippy::useless_attribute)]

mod a {
    mod b {
        #[allow(unreachable_pub)]
        pub struct C {}
    }
    #[allow(unreachable_pub)]
    pub use b::C;
}

Playground
@taiki-e taiki-e mentioned this issue May 17, 2019
Merged
bors added a commit that referenced this issue May 19, 2019
@bors
Auto merge of #4107 - taiki-e:useless_attribute, r=flip1995
0417a0a 
useless_attribute: Add unreachable_pub to whitelists

Fixes #4106

changelog: `useless_attribute`: whitelist `unreachable_pub` on `use` items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

useless_attribute: Add unreachable_pub to whitelists taiki-e/rust-clippy
1 participant
@taiki-e