Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rustc internal lints in Clippy #3965

Closed
flip1995 opened this issue Apr 15, 2019 · 0 comments · Fixed by #3966
Closed

Use rustc internal lints in Clippy #3965

flip1995 opened this issue Apr 15, 2019 · 0 comments · Fixed by #3966
Assignees

Comments

@flip1995
Copy link
Member

In rust-lang/rust#59316 internal lints were implemented. Let's also activate those in Clippy.

This includes removing the internal lint

declare_clippy_lint! {
/// **What it does:** Checks for the presence of the default hash types "HashMap" or "HashSet"
/// and recommends the FxHash* variants.
///
/// **Why is this bad?** The FxHash variants have better performance
/// and we don't need any collision prevention in clippy.
pub DEFAULT_HASH_TYPES,
internal,
"forbid HashMap and HashSet and suggest the FxHash* variants"
}

from Clippy, since it got uplifted.

@flip1995 flip1995 self-assigned this Apr 15, 2019
bors added a commit that referenced this issue Apr 16, 2019
Enable rustc internal lints

Closes #3965

I'm not 100% sure if enabling the `-Zunstable-options` flag in the `.cargo/config` file is the right place.
bors added a commit that referenced this issue Apr 17, 2019
Enable rustc internal lints

Closes #3965

I'm not 100% sure if enabling the `-Zunstable-options` flag in the `.cargo/config` file is the right place.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant