Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cast_ptr_alignment should include a note with the alignment of types involved #3797

Closed
gnzlbg opened this issue Feb 22, 2019 · 0 comments · Fixed by #4257
Closed

cast_ptr_alignment should include a note with the alignment of types involved #3797

gnzlbg opened this issue Feb 22, 2019 · 0 comments · Fixed by #4257

Comments

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 22, 2019

Playground:

fn main() {
    unsafe {
        use std::mem::transmute;
        let a = 0_u8;
        let b = &a as *const u8 as *const u64;
        //let _c: &u64 = transmute(b);
        let _d = *b;
    }
}

makes cast_ptr_alignment report

error: casting from `*const u8` to a more-strictly-aligned pointer (`*const u64`)

We might want to add a note stating what the alignment of u8 and of u64 is.

bors added a commit that referenced this issue Jul 9, 2019
Improve cast_ptr_alignment lint

<!--
Thank you for making Clippy better!

We're collecting our changelog from pull request descriptions.
If your PR only updates to the latest nightly, you can leave the
`changelog` entry as `none`. Otherwise, please write a short comment
explaining your change.

If your PR fixes an issue, you can add "fixes #issue_number" into this
PR description. This way the issue will be automatically closed when
your PR is merged.

If you added a new lint, here's a checklist for things that will be
checked during review or continuous integration.

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `util/dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo fmt`

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

Delete this line and everything above before opening your PR -->

* print alignment in bytes in the lint message
* ignore ZST left-hand types

Fixes #3797 and #4256
changelog:
* `cast_ptr_alignment`: Print alignment in bytes in the lint message
* `cast_ptr_alignment`: Ignore casting from ZST left-hand types
@bors bors closed this as completed in #4257 Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant