Clippy recommends use of unstable Self constructors, which cause an ICE

[DianaNites]

This is using clippy clippy 0.0.212 (2e26fdc2 2018-11-22)

Given this example, clippy will suggest TestStruct::from_something() entirely be replaced with Self(), which is incorrect, and causes the compiler to ICE due to rust-lang/rust#56611

Of note is that VSCode with RLS will offer code actions to automatically do this transformation.

[mati865]

ICE doesn't matter here, it's Rust bug and nightly is fixed already.

Currently Clippy reports:

warning: unnecessary structure name repetition
  --> src/main.rs:16:9
   |
16 |         TestStruct::from_something()
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`

Tools replace TestStruct::from_something with Self resulting in Self().

To make it work properly only TestStruct should be replaced like that:

16 |         TestStruct::from_something()
   |         ^^^^^^^^^^ help: use the applicable keyword: `Self`

[detrumi]

It's the use_self lint, and there are some invalid suggestions in the current tests too, such as:

error: unnecessary structure name repetition
  --> $DIR/use_self.rs:30:13
   |
LL |             Foo::new()
   |             ^^^^^^^^ help: use the applicable keyword: `Self`

I'll take a look at this.