-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustfmt incompatibility: possibly missing a comma here #3244
Comments
I would say |
I think that there is an error on both clippy and rustfmt. rustfmt should either put |
3407: Fix `possible_missing_comma` false positives r=oli-obk a=mikerite `possible_missing_comma` should only trigger when the binary operator has unary equivalent. Otherwise, it's not possible to insert a comma without breaking compilation. The operators identified were `+`, `&`, `*` and `-`. This fixes the specific examples given in issues #3244 and #3396 but doesn't address the conflict this lint has with the style of starting a line with a binary operator. Co-authored-by: Michael Wright <[email protected]>
for such code clippy (from rustup/stable | 0.0.212) clippy show error:
the problem that this is default coding style from rustfmt that comes with rustup/stable compiler,
it is possible to fix if reformat code like this
* C / 60.
, butrustfmt
doesn't allow such coding style by default.Not sure is this rustfmt issue or clippy, but clippy and rustfmt runs on CI,
and clippy fails.
The text was updated successfully, but these errors were encountered: