-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
125 additions
and
121 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,141 +1,211 @@ | ||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:24:5 | ||
--> $DIR/unit_arg.rs:23:5 | ||
| | ||
LL | foo({}); | ||
| ^^^^^^^ | ||
| | ||
= note: `-D clippy::unit-arg` implied by `-D warnings` | ||
help: move the expressions in front of the call... | ||
help: move the expression in front of the call... | ||
| | ||
LL | {}; foo({}); | ||
| ^^^ | ||
help: ...and use unit literals instead | ||
LL | {}; | ||
| | ||
help: ...and use a unit literal instead | ||
| | ||
LL | foo(()); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:25:5 | ||
--> $DIR/unit_arg.rs:24:5 | ||
| | ||
LL | / foo({ | ||
LL | | 1; | ||
LL | | }); | ||
| |______^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | 1 | ||
| | ||
help: or move the expression in front of the call... | ||
| | ||
LL | { | ||
LL | 1; | ||
LL | }; foo({ | ||
LL | }; | ||
| | ||
help: ...and use unit literals instead | ||
help: ...and use a unit literal instead | ||
| | ||
LL | foo(()); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:28:5 | ||
--> $DIR/unit_arg.rs:27:5 | ||
| | ||
LL | foo(foo(1)); | ||
| ^^^^^^^^^^^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: move the expression in front of the call... | ||
| | ||
LL | foo(1); foo(foo(1)); | ||
| ^^^^^^^ | ||
help: ...and use unit literals instead | ||
LL | foo(1); | ||
| | ||
help: ...and use a unit literal instead | ||
| | ||
LL | foo(()); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:29:5 | ||
--> $DIR/unit_arg.rs:28:5 | ||
| | ||
LL | / foo({ | ||
LL | | foo(1); | ||
LL | | foo(2); | ||
LL | | }); | ||
| |______^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | foo(2) | ||
| | ||
help: or move the expression in front of the call... | ||
| | ||
LL | { | ||
LL | foo(1); | ||
LL | foo(2); | ||
LL | }; foo({ | ||
LL | }; | ||
| | ||
help: ...and use unit literals instead | ||
help: ...and use a unit literal instead | ||
| | ||
LL | foo(()); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:33:5 | ||
--> $DIR/unit_arg.rs:32:5 | ||
| | ||
LL | foo3({}, 2, 2); | ||
| ^^^^^^^^^^^^^^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: move the expression in front of the call... | ||
| | ||
LL | {}; foo3({}, 2, 2); | ||
| ^^^ | ||
help: ...and use unit literals instead | ||
LL | {}; | ||
| | ||
help: ...and use a unit literal instead | ||
| | ||
LL | foo3((), 2, 2); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:35:5 | ||
--> $DIR/unit_arg.rs:34:5 | ||
| | ||
LL | / b.bar({ | ||
LL | | 1; | ||
LL | | }); | ||
| |______^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | 1 | ||
| | ||
help: or move the expression in front of the call... | ||
| | ||
LL | { | ||
LL | 1; | ||
LL | }; b.bar({ | ||
LL | }; | ||
| | ||
help: ...and use unit literals instead | ||
help: ...and use a unit literal instead | ||
| | ||
LL | b.bar(()); | ||
| ^^ | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:38:5 | ||
error: passing unit values to a function | ||
--> $DIR/unit_arg.rs:37:5 | ||
| | ||
LL | taking_multiple_units(foo(0), foo(1)); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
help: move the expressions in front of the call... | ||
| | ||
LL | foo(0); foo(1); taking_multiple_units(foo(0), foo(1)); | ||
| ^^^^^^^^^^^^^^^ | ||
LL | foo(0); | ||
LL | foo(1); | ||
| | ||
help: ...and use unit literals instead | ||
| | ||
LL | taking_multiple_units((), foo(1)); | ||
| ^^ | ||
LL | taking_multiple_units((), ()); | ||
| ^^ ^^ | ||
|
||
error: passing unit values to a function | ||
--> $DIR/unit_arg.rs:38:5 | ||
| | ||
LL | / taking_multiple_units(foo(0), { | ||
LL | | foo(1); | ||
LL | | foo(2); | ||
LL | | }); | ||
| |______^ | ||
| | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | foo(2) | ||
| | ||
help: or move the expressions in front of the call... | ||
| | ||
LL | foo(0); | ||
LL | { | ||
LL | foo(1); | ||
LL | foo(2); | ||
LL | }; | ||
| | ||
help: ...and use unit literals instead | ||
| | ||
LL | taking_multiple_units(foo(0), ()); | ||
| ^^ | ||
LL | taking_multiple_units((), ()); | ||
| ^^ ^^ | ||
|
||
error: passing unit values to a function | ||
--> $DIR/unit_arg.rs:42:5 | ||
| | ||
LL | / taking_multiple_units( | ||
LL | | { | ||
LL | | foo(0); | ||
LL | | foo(1); | ||
... | | ||
LL | | }, | ||
LL | | ); | ||
| |_____^ | ||
| | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | foo(1) | ||
| | ||
help: remove the semicolon from the last statement in the block | ||
| | ||
LL | foo(3) | ||
| | ||
help: or move the expressions in front of the call... | ||
| | ||
LL | { | ||
LL | foo(0); | ||
LL | foo(1); | ||
LL | }; | ||
LL | { | ||
LL | foo(2); | ||
... | ||
help: ...and use unit literals instead | ||
| | ||
LL | (), | ||
LL | (), | ||
| | ||
|
||
error: passing a unit value to a function | ||
--> $DIR/unit_arg.rs:71:5 | ||
--> $DIR/unit_arg.rs:84:5 | ||
| | ||
LL | Some(foo(1)) | ||
| ^^^^^^^^^^^^ | ||
| | ||
help: move the expressions in front of the call... | ||
help: move the expression in front of the call... | ||
| | ||
LL | foo(1); Some(foo(1)) | ||
| ^^^^^^^ | ||
help: ...and use unit literals instead | ||
LL | foo(1); | ||
| | ||
help: ...and use a unit literal instead | ||
| | ||
LL | Some(()) | ||
| ^^ | ||
|
||
error: aborting due to 8 previous errors | ||
error: aborting due to 10 previous errors | ||
|