A couple of fixes for the Box, stack and heap chapter.
#1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all the instances of `in the heap/stack` into `on the heap/stack`. This form is widely accepted within the industry, and consistent with the "The Rust Programming Language" book.
Changed a single `=` (assignment) into `==` (equality), which was clearly the author's original intention.
|
r? @marioidival (rust_highfive has picked a reviewer for you, use r? to override) |
marioidival
approved these changes
Jun 24, 2019
|
@Rosto75 thank you |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update books Update nomicon, reference, book, rust-by-example, rustc-guide ## nomicon 2 commits in c656171b749b7307f21371dd0d3278efee5573b8..341c221116a8b9f1010cf1eece952b80c5ec7f54 2019-04-25 15:31:26 -0400 to 2019-06-19 09:08:47 -0700 - Fix some links. - cleanup the intro, and clarify how it relates to the reference (rust-lang/nomicon#140) ## reference 2 commits in 08ae27a..7a5aab5 2019-06-17 11:24:13 -0700 to 2019-06-20 17:38:52 +0200 - Update for cfg on generic parameter. (rust-lang/reference#624) - Link to "const functions" section from constant expressions list (rust-lang/reference#623) ## book 2 commits in 9aacfcc4c5b102c8cda195932addefd32fe955d2..6c0d83499c8e77e06a71d28c5e1adccec278d4f3 2019-06-16 21:27:26 -0400 to 2019-06-23 20:25:30 -0400 - fancy quotes - Edits made in copyedit ## rust-by-example 2 commits in b27472962986e85c94f4183b1a6d2207660d3ed6..62b3ff2cb44dd8b648c3ef2a9347c3706d148014 2019-06-17 15:52:07 -0300 to 2019-06-24 09:17:21 -0300 - A couple of fixes for the `Box, stack and heap` chapter. (rust-lang/rust-by-example#1206) - [typo] Note, that it is -> Note that, it is (rust-lang/rust-by-example#1207) ## rustc-guide 38 commits in f55e97c145cf37fd664db2e0e2f2d05df328bf4f..abf512fc9cc969dcbea69aa15b44586bbeb13c2d 2019-06-15 17:29:12 -0500 to 2019-06-26 11:05:58 -0500 - fix long line - add `point` to the glossary and link a use of it - fix indentation - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/constraint_propagation.md - adjust overview slightly - describe region inference and member constraints in some detail - start filling out the constraint propagation chapter in more detail - break out parts of the region inference chapter into sub-chapters - fix typo - avoid ftp links - fix broken links - add bibligraphy appendix - Update to mdbook-linkcheck 0.3.0 - Update mdbook - Change stage0 cfg_attr to bootstrap - fix compiler-team - Added Rustc Debugger Support Chapter
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update books Update nomicon, reference, book, rust-by-example, rustc-guide ## nomicon 2 commits in c656171b749b7307f21371dd0d3278efee5573b8..341c221116a8b9f1010cf1eece952b80c5ec7f54 2019-04-25 15:31:26 -0400 to 2019-06-19 09:08:47 -0700 - Fix some links. - cleanup the intro, and clarify how it relates to the reference (rust-lang/nomicon#140) ## reference 2 commits in 08ae27a..7a5aab5 2019-06-17 11:24:13 -0700 to 2019-06-20 17:38:52 +0200 - Update for cfg on generic parameter. (rust-lang/reference#624) - Link to "const functions" section from constant expressions list (rust-lang/reference#623) ## book 2 commits in 9aacfcc4c5b102c8cda195932addefd32fe955d2..6c0d83499c8e77e06a71d28c5e1adccec278d4f3 2019-06-16 21:27:26 -0400 to 2019-06-23 20:25:30 -0400 - fancy quotes - Edits made in copyedit ## rust-by-example 2 commits in b27472962986e85c94f4183b1a6d2207660d3ed6..62b3ff2cb44dd8b648c3ef2a9347c3706d148014 2019-06-17 15:52:07 -0300 to 2019-06-24 09:17:21 -0300 - A couple of fixes for the `Box, stack and heap` chapter. (rust-lang/rust-by-example#1206) - [typo] Note, that it is -> Note that, it is (rust-lang/rust-by-example#1207) ## rustc-guide 38 commits in f55e97c145cf37fd664db2e0e2f2d05df328bf4f..abf512fc9cc969dcbea69aa15b44586bbeb13c2d 2019-06-15 17:29:12 -0500 to 2019-06-26 11:05:58 -0500 - fix long line - add `point` to the glossary and link a use of it - fix indentation - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/constraint_propagation.md - adjust overview slightly - describe region inference and member constraints in some detail - start filling out the constraint propagation chapter in more detail - break out parts of the region inference chapter into sub-chapters - fix typo - avoid ftp links - fix broken links - add bibligraphy appendix - Update to mdbook-linkcheck 0.3.0 - Update mdbook - Change stage0 cfg_attr to bootstrap - fix compiler-team - Added Rustc Debugger Support Chapter
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update books Update nomicon, reference, book, rust-by-example, rustc-guide ## nomicon 2 commits in c656171b749b7307f21371dd0d3278efee5573b8..341c221116a8b9f1010cf1eece952b80c5ec7f54 2019-04-25 15:31:26 -0400 to 2019-06-19 09:08:47 -0700 - Fix some links. - cleanup the intro, and clarify how it relates to the reference (rust-lang/nomicon#140) ## reference 2 commits in 08ae27a..7a5aab5 2019-06-17 11:24:13 -0700 to 2019-06-20 17:38:52 +0200 - Update for cfg on generic parameter. (rust-lang/reference#624) - Link to "const functions" section from constant expressions list (rust-lang/reference#623) ## book 2 commits in 9aacfcc4c5b102c8cda195932addefd32fe955d2..6c0d83499c8e77e06a71d28c5e1adccec278d4f3 2019-06-16 21:27:26 -0400 to 2019-06-23 20:25:30 -0400 - fancy quotes - Edits made in copyedit ## rust-by-example 2 commits in b27472962986e85c94f4183b1a6d2207660d3ed6..62b3ff2cb44dd8b648c3ef2a9347c3706d148014 2019-06-17 15:52:07 -0300 to 2019-06-24 09:17:21 -0300 - A couple of fixes for the `Box, stack and heap` chapter. (rust-lang/rust-by-example#1206) - [typo] Note, that it is -> Note that, it is (rust-lang/rust-by-example#1207) ## rustc-guide 38 commits in f55e97c145cf37fd664db2e0e2f2d05df328bf4f..abf512fc9cc969dcbea69aa15b44586bbeb13c2d 2019-06-15 17:29:12 -0500 to 2019-06-26 11:05:58 -0500 - fix long line - add `point` to the glossary and link a use of it - fix indentation - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/constraint_propagation.md - adjust overview slightly - describe region inference and member constraints in some detail - start filling out the constraint propagation chapter in more detail - break out parts of the region inference chapter into sub-chapters - fix typo - avoid ftp links - fix broken links - add bibligraphy appendix - Update to mdbook-linkcheck 0.3.0 - Update mdbook - Change stage0 cfg_attr to bootstrap - fix compiler-team - Added Rustc Debugger Support Chapter
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 27, 2019
Update books Update nomicon, reference, book, rust-by-example, rustc-guide ## nomicon 2 commits in c656171b749b7307f21371dd0d3278efee5573b8..341c221116a8b9f1010cf1eece952b80c5ec7f54 2019-04-25 15:31:26 -0400 to 2019-06-19 09:08:47 -0700 - Fix some links. - cleanup the intro, and clarify how it relates to the reference (rust-lang/nomicon#140) ## reference 2 commits in 08ae27a..7a5aab5 2019-06-17 11:24:13 -0700 to 2019-06-20 17:38:52 +0200 - Update for cfg on generic parameter. (rust-lang/reference#624) - Link to "const functions" section from constant expressions list (rust-lang/reference#623) ## book 2 commits in 9aacfcc4c5b102c8cda195932addefd32fe955d2..6c0d83499c8e77e06a71d28c5e1adccec278d4f3 2019-06-16 21:27:26 -0400 to 2019-06-23 20:25:30 -0400 - fancy quotes - Edits made in copyedit ## rust-by-example 2 commits in b27472962986e85c94f4183b1a6d2207660d3ed6..62b3ff2cb44dd8b648c3ef2a9347c3706d148014 2019-06-17 15:52:07 -0300 to 2019-06-24 09:17:21 -0300 - A couple of fixes for the `Box, stack and heap` chapter. (rust-lang/rust-by-example#1206) - [typo] Note, that it is -> Note that, it is (rust-lang/rust-by-example#1207) ## rustc-guide 38 commits in f55e97c145cf37fd664db2e0e2f2d05df328bf4f..abf512fc9cc969dcbea69aa15b44586bbeb13c2d 2019-06-15 17:29:12 -0500 to 2019-06-26 11:05:58 -0500 - fix long line - add `point` to the glossary and link a use of it - fix indentation - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/placeholders_and_universes.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/member_constraints.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/constraint_propagation.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/lifetime_parameters.md - Update src/borrow_check/region_inference/constraint_propagation.md - adjust overview slightly - describe region inference and member constraints in some detail - start filling out the constraint propagation chapter in more detail - break out parts of the region inference chapter into sub-chapters - fix typo - avoid ftp links - fix broken links - add bibligraphy appendix - Update to mdbook-linkcheck 0.3.0 - Update mdbook - Change stage0 cfg_attr to bootstrap - fix compiler-team - Added Rustc Debugger Support Chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.