ir: Sanitize base names more aggressively #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth cc @upsuper |
fitzgen
approved these changes
Aug 11, 2017
src/ir/ty.rs
Outdated
| return Cow::Borrowed(name) | ||
| } | ||
|
|
||
| Cow::Owned(name.replace(|c| c == ' ' || c == ':' || c == '.' , "_")) |
There was a problem hiding this comment.
Maybe assert that it is a valid identifier after this treatment?
There was a problem hiding this comment.
Or perhaps just replace all non-ident chars?
Manishearth
approved these changes
Aug 11, 2017
emilio
force-pushed
the
stylo-build-woes
branch
from
9c00e02 to
20f2ed2
Compare
|
@bors-servo r=fitzgen,Manishearth |
|
📌 Commit 20f2ed2 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 11, 2017
ir: Sanitize base names more aggressively This fixes stylo build failures when template instantiations tests caused a rust compile error due to a bad test name. This commit makes names better sanitized, preventing similar errors in the future.
|
💔 Test failed - status-travis |
|
@bors-servo retry
|
bors-servo
pushed a commit
that referenced
this pull request
Aug 13, 2017
ir: Sanitize base names more aggressively This fixes stylo build failures when template instantiations tests caused a rust compile error due to a bad test name. This commit makes names better sanitized, preventing similar errors in the future.
|
💔 Test failed - status-travis |
This fixes stylo build failures when template instantiations tests caused a rust compile error due to a bad test name. This commit makes names better sanitized, preventing similar errors in the future.
emilio
force-pushed
the
stylo-build-woes
branch
from
20f2ed2 to
b2bed30
Compare
|
or maybe I'm just stupid. The assertion doesn't hold for every type because of stuff like @bors-servo r=manishearth,fitzgen |
|
📌 Commit b2bed30 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Aug 13, 2017
ir: Sanitize base names more aggressively This fixes stylo build failures when template instantiations tests caused a rust compile error due to a bad test name. This commit makes names better sanitized, preventing similar errors in the future.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes stylo build failures when template instantiations tests caused a rust
compile error due to a bad test name.
This commit makes names better sanitized, preventing similar errors in the
future.