Have tests pass on Windows #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
r? @emilio |
|
@bors-servo r+ Thanks a lot for this Xidorn! ❤️ |
|
📌 Commit 2944834 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 20, 2017
Have tests pass on Windows These changes allow `cargo test` to pass on Windows. There are two followup work we should do at some point: * setup AppVeyor so that we don't break Windows development either * convert `no_system_header_includes` to be pure Rust so that it supports Windows natively
|
☀️ Test successful - status-travis |
|
@upsuper awesome! Thanks! The faster appveyor is set up, the less likely this is to regress in the future. Do you have experience with appveyor (I don't)? If so, would you be willing to set it up for us? Thanks again! |
|
I don't either, unfortunately... |
|
I know @UK992 has helped a lot with servo's appveyor integration. A hand here would be quite nice if he could! (no worries if not) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow
cargo testto pass on Windows.There are two followup work we should do at some point:
no_system_header_includesto be pure Rust so that it supports Windows natively