Remove Type::detect_has_vtable_cycle. #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
|
Can you squash the commits please? Thanks! |
After some discussion in rust-lang#765 we do not think anymore this it can ever be true.
SirVer
force-pushed
the
00_fix_repetition_operation
branch
from
1850ba8 to
672b740
Compare
|
@emilio Done. My 2c: In my humble opinion this should be done by the merge bot. It is quite useful to keep the history of the commits in the related PR to see the development of the discussion and GitHub does not deal well with rebasing. GitHubs own merge tools actually allow for that - squashing everything into one commit on merge. The mergebot could do that too - the only question is which commit message to use. In my projects the tradition is to use the OP as the commit message and edit it to always reflect the state of the PR. |
|
@bors-servo r=emilio |
|
📌 Commit 672b740 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 5, 2017
Remove Type::detect_has_vtable_cycle. After some discussion in #765 we do not think anymore that this can ever be true.
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some discussion in #765 we do not think anymore that this can ever be true.