Allow marking specific template instantiations as opaque #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fitzgen
commented
Jun 21, 2017
src/ir/template.rs
Outdated
| // `canonical_name` does not insert the template arguments into the | ||
| // name, ie it for nested template arguments it creates "Foo" instead of | ||
| // "Foo<int>". The fully correct fix is to make `canonical_{name,path}` | ||
| // include template arguments properly. |
There was a problem hiding this comment.
For the record, I tried doing this the right way, but it's so messy because all the different places we assume names can or can't have non-ident characters and things like that. Need to file a bug to put the issue number here.
Closed
fitzgen
force-pushed
the
allow-making-particular-instantiations-opaque
branch
from
1fb0b32 to
90c23fb
Compare
emilio
approved these changes
Jun 22, 2017
If a template has a specialization that bindgen doesn't understand, it can be helpful to mark it as opaque and continue making forward progress in the meantime. This is something we need in the SpiderMonkey bindings.
fitzgen
force-pushed
the
allow-making-particular-instantiations-opaque
branch
from
90c23fb to
2000177
Compare
|
Thanks Emilio! @bors-servo r=emilio |
|
📌 Commit 2000177 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 22, 2017
…paque, r=emilio Allow marking specific template instantiations as opaque If a template has a specialization that bindgen doesn't understand, it can be helpful to mark it as opaque and continue making forward progress in the meantime. This is something we need in the SpiderMonkey bindings. r? @emilio
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a template has a specialization that bindgen doesn't understand, it can be
helpful to mark it as opaque and continue making forward progress in the
meantime. This is something we need in the SpiderMonkey bindings.
r? @emilio