codegen: Respect original repr for bitfield-like enums, add a constifying variant. #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jan 24, 2017
| /// constant. | ||
| /// | ||
| /// This makes bindgen generate constants instead of enums. | ||
| pub fn constified_enum<T: AsRef<str>>(mut self, arg: T) -> Builder { |
There was a problem hiding this comment.
Add documentation that this takes a regexp?
|
r=me with that small doc about regexps |
emilio
force-pushed
the
constify-all-enums
branch
from
4ed28b0 to
0df8441
Compare
|
@bors-servo r=fitzgen |
|
📌 Commit 0df8441 has been approved by |
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @fitzgen
Fixes #430