Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The which dependency was introduced alongside the ability for bindgen to call rustfmt: #905
Theres been some dancing around the need for this dependency, with a feature added to disable it back in 2019 #1615
But I dont believe its actually required at all and in this PR I propose that we can just remove it entirely.
My understanding is that
which
will check the PATH for any binaries matching the passed name.However if we were to just attempt to execute that name directly the OS would perform the exact same operation, checking the PATH for any binaries matching the name.
So we should just directly execute
rustfmt
, unless its overridden by theRUSTFMT
env var.If my understanding is incorrect, lets instead document why which is needed.