-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-introduce docopt #202
Re-introduce docopt #202
Conversation
So,
Thanks. 😄 |
I'm not sure how to convince
@BurntSushi, suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only a few nits.
It'd be nice to have the --raw-line ''
working, I'll reply to the other comments now.
|
||
// Input header | ||
let header = args.get_str("<input-header>"); | ||
if header != "" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: If !header.is_empty()
? Here and below.
Yep, I think it's unused since a while ago, and it works on MSVC, see #54. Let's get rid of it. |
This flag is intended only to be a debugging aid, so making it only spit to stdout is fine. |
☔ The latest upstream changes (presumably #206) made this pull request unmergeable. Please resolve the merge conflicts. |
Fixes rust-lang#87. - Tidy up usage string - Switch to using bindgen::Builder directly in main() - Builder required some new methods - `--use-msvc-mangling` appears to be deprecated, and is only referenced in `src/lib.rs`. I have added a Deprecated section to the usage string so using the flag doesn't cause errors - `--emit-clang-ast` doesn't currently disable output of Rust bindings, might have to do something tricky here - Added `--version` based on CARGO_PKG_* - Need to add some error handling to `<input-header>`
Interesting, @BurntSushi wants to move ripgrep to clap: BurntSushi/ripgrep#136 I'm going to let this PR cool and come back to it after the crate split discussed in #204. Then clap it. 👏 |
☔ The latest upstream changes (presumably #218) made this pull request unmergeable. Please resolve the merge conflicts. |
This PR has no future. |
Clap your hands say yeah! 👏🏻 In progress port to `clap`, obsoletes the `docopt` port in #202.
Fixes #87.
--use-msvc-mangling
appears to be deprecated, and is only referencedin
src/lib.rs
. I have added a Deprecated section to the usage stringso using the flag doesn't cause errors
--emit-clang-ast
doesn't currently disable output of Rust bindings,might have to do something tricky here
--version
based on CARGO_PKG_*<input-header>