-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layout with packed class that only has a vtable #1495
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
/* automatically generated by rust-bindgen */ | ||
|
||
#![allow( | ||
dead_code, | ||
non_snake_case, | ||
non_camel_case_types, | ||
non_upper_case_globals | ||
)] | ||
#![cfg(feature = "nightly")] | ||
|
||
#[repr(C)] | ||
pub struct PackedVtable__bindgen_vtable(::std::os::raw::c_void); | ||
#[repr(C, packed)] | ||
#[derive(Debug)] | ||
pub struct PackedVtable { | ||
pub vtable_: *const PackedVtable__bindgen_vtable, | ||
} | ||
#[test] | ||
fn bindgen_test_layout_PackedVtable() { | ||
assert_eq!( | ||
::std::mem::size_of::<PackedVtable>(), | ||
8usize, | ||
concat!("Size of: ", stringify!(PackedVtable)) | ||
); | ||
assert_eq!( | ||
::std::mem::align_of::<PackedVtable>(), | ||
1usize, | ||
concat!("Alignment of ", stringify!(PackedVtable)) | ||
); | ||
} | ||
impl Default for PackedVtable { | ||
fn default() -> Self { | ||
unsafe { ::std::mem::zeroed() } | ||
} | ||
} | ||
extern "C" { | ||
#[link_name = "\u{1}_ZN12PackedVtableD1Ev"] | ||
pub fn PackedVtable_PackedVtable_destructor(this: *mut PackedVtable); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
// bindgen-flags: --raw-line '#![cfg(feature = "nightly")]' --rust-target 1.33 -- -x c++ -std=c++11 | ||
|
||
#pragma pack(1) | ||
|
||
// This should be packed. | ||
struct PackedVtable { | ||
virtual ~PackedVtable(); | ||
}; | ||
|
||
#pragma pack() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this really be an
else
condition?Or should it be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It passes either way, so I guess it doesn't really matter. A class without data members won't ever pass that first condition. I can reword it if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's fine, I was wondering if this would allow catching stuff where we don't know the layout of the members because libclang doesn't expose it, yet we know we have a vtable. Anyhow this is fine.