ir: Handle *const T at the codegen level. #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fitzgen |
fitzgen
approved these changes
May 15, 2018
|
I had a feeling this may fix some odd cases of mixing const and non-const pointer... Since you insisted it I found a test-case and I just added it :) @bors-servo r=fitzgen |
|
📌 Commit 716d53b has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 15, 2018
ir: Handle *const T at the codegen level. Followup to #1311.
|
☀️ Test successful - status-travis |
|
Thanks for all the effort! However, I am wondering when we can expect a version bump with the recent changes. sodiumoxide/sodiumoxide#208 is actually waiting for an upstream release with these changes. |
|
Hi! Just published v0.37.0. Thank you!
…On 05/17/2018 06:14 PM, cynecx wrote:
Thanks for all the effort! However, I am wondering when we can expect a
version bump with the recent changes. sodiumoxide/sodiumoxide#208
<sodiumoxide/sodiumoxide#208> is actually
waiting for an upstream release with these changes.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1312 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQwuvktLK9-MCxUUs0KNlHyuhJJwj4mks5tzaHTgaJpZM4T-LTM>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1311.