-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Don't build clap if we're being used as a library. #1111
Conversation
This works around rust-lang/cargo#1982 by using required-features.
r? @fitzgen |
(or @pepyakin, or anyone else really) |
So, now instead of |
Hmm... Not that I know of unfortunately. |
|
We can also make |
Doesn’t |
@SimonSapin my first impression was the same :) But when I tried
|
That’s just silly… but I suspect that fixing it properly in Cargo requires fixing rust-lang/cargo#4463 first. |
☔ The latest upstream changes (presumably #1126) made this pull request unmergeable. Please resolve the merge conflicts. |
Closing in favor of #1581 |
This allows Firefox not to build clap.