Enable --rustfmt-bindings by default

[harlanhaskins]

This patch flips --rustfmt-bindings to --no-rustfmt-bindings and enables
formatting by default. If rustfmt is not accessible, a warning is
printed and the bindings are printed unformatted.

Addresses #977.

[harlanhaskins]

This still has 357 failing tests because the existing expected output is unformatted. For the purpose of this patch, should I update all the test cases or pass --no-rustfmt-bindings instead?

Never mind, looks like I misinterpreted things.

[fitzgen]

This looks good to me -- thanks! Is there still anything outstanding that I'm not seeing that is keeping this PR "WIP"?

[harlanhaskins]

Not really, no! Unless -- should I add the flag back in and mark it deprecated?

[fitzgen]

Not really, no! Unless -- should I add the flag back in and mark it deprecated?

Yeah, let's do that, good idea.

[harlanhaskins]

@fitzgen Good to merge?

[fitzgen]

@fitzgen Good to merge?

Sorry, didn't see that you pushed new commits -- sometimes I don't get those emails for some reason...

[fitzgen]

@bors-servo r+

Thanks @harlanhaskins !

[bors-servo]

📌 Commit 89b4dbc has been approved by fitzgen

[bors-servo]

⌛ Testing commit 89b4dbc with merge 81c634b...

[bors-servo]

💔 Test failed - status-travis

[harlanhaskins]

Looks like it failed downloading components:
https://travis-ci.org/rust-lang-nursery/rust-bindgen/jobs/279586683

Can we re-run the tests?

[fitzgen]

Retriggered.

…

On Mon, Sep 25, 2017 at 10:19 AM, Harlan ***@***.***> wrote: Looks like it failed downloading components: https://travis-ci.org/rust-lang-nursery/rust-bindgen/jobs/279586683 Can we re-run the tests? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#1022 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEjS9XIJmK4EIgn0M6cb024pF3QQoLbks5sl-C7gaJpZM4PhK3D> .

[fitzgen]

Did you delete the branch? Can you un-delete it until this is fully merged? On Mon, Sep 25, 2017 at 10:21 AM, Nick Fitzgerald <[email protected]> wrote:

…

Retriggered. On Mon, Sep 25, 2017 at 10:19 AM, Harlan ***@***.***> wrote: > Looks like it failed downloading components: > https://travis-ci.org/rust-lang-nursery/rust-bindgen/jobs/279586683 > > Can we re-run the tests? > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#1022 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AAEjS9XIJmK4EIgn0M6cb024pF3QQoLbks5sl-C7gaJpZM4PhK3D> > . >

[harlanhaskins]

I haven’t deleted the branch...

[fitzgen]

Huh. Retriggered once again. Was seeing

$ cd rust-lang-nursery/rust-bindgen
$ git checkout -qf 81c634b8628b0bf2d34f521a7824d68058a53c8f
fatal: reference is not a tree: 81c634b8628b0bf2d34f521a7824d68058a53c8f
The command "git checkout -qf 81c634b8628b0bf2d34f521a7824d68058a53c8f" failed and exited with 128 during .
Your build has been stopped.

Which is usually what happens when the branch gets deleted before CI finishes.

[fitzgen]

@bors-servo retry

[bors-servo]

⌛ Testing commit 89b4dbc with merge 9113b7b...

[bors-servo]

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 9113b7b to master...