Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive ord when possible #1003

Merged
merged 4 commits into from
Sep 19, 2017

Conversation

pepyakin
Copy link
Contributor

Fixes #884

r? @fitzgen

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

@bors-servo r+

@bors-servo
Copy link

📌 Commit 27dad0b has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 27dad0b with merge de0180e...

bors-servo pushed a commit that referenced this pull request Sep 19, 2017
@bors-servo
Copy link

💔 Test failed - status-travis

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

(Note that Travis CI got stuck so I canceled and restarted a job, that isn't actually a test failure)

@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing de0180e to master...

@bors-servo bors-servo merged commit 27dad0b into rust-lang:master Sep 19, 2017
@pepyakin pepyakin deleted the derive-ord-when-possible branch September 21, 2017 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants