Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive PartialOrd when possible #1002

Merged
merged 5 commits into from
Sep 19, 2017

Conversation

pepyakin
Copy link
Contributor

Fixes #882

r? @fitzgen

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

This looks good!

We just need some test coverage to land this. Let's add --with-derive-partialord to the // bindgen-flags line for these tests:

  • tests/headers/derive-hash-template-inst-float.hpp
  • tests/headers/derive-hash-template-def-float.hpp
  • tests/headers/derive-hash-struct-with-pointer.h
  • tests/headers/derive-hash-struct-with-float-array.h
  • tests/headers/derive-hash-struct-with-anon-struct-float.h
  • tests/headers/derive-hash-blacklisting.hpp

And then verify that the generated bindings do or don't derive(PartialOrd) as we expect them to.

Thanks!

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

@pepyakin, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on bindgen during the impl period are hanging out in https://gitter.im/rust-impl-period/WG-dev-tools-bindgen if you want to join us :)

@fitzgen
Copy link
Member

fitzgen commented Sep 19, 2017

@bors-servo r+

Thanks @pepyakin !

@bors-servo
Copy link

📌 Commit e4a4b47 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit e4a4b47 with merge 1906a26...

bors-servo pushed a commit that referenced this pull request Sep 19, 2017
…zgen

Derive PartialOrd when possible

Fixes #882

r? @fitzgen
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

1 similar comment
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

@bors-servo bors-servo merged commit e4a4b47 into rust-lang:master Sep 19, 2017
@pepyakin pepyakin deleted the derive-partialord-when-possible branch September 19, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants