Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Builder::whitelist_function; deprecate Builder::whitelisted_function #985

Closed
3 tasks
fitzgen opened this issue Sep 13, 2017 · 4 comments
Closed
3 tasks

Add Builder::whitelist_function; deprecate Builder::whitelisted_function #985

fitzgen opened this issue Sep 13, 2017 · 4 comments
Labels
C-assigned E-easy enhancement help wanted I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Sep 13, 2017 •
edited
Loading

The CLI flag is --whitelist-function, so we should be consistent and remove the "ed" from the builder method.

  • Rename Builder::whitelisted_function to Builder::whitelist_function
  • Add Builder::whitelisted_function that delegates to whitelist_function
  • Mark whitelisted_function as #[deprecated = "use whitelist_function instead"]
@highfive
Copy link

Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the #servo channel in IRC.

If you intend to work on this issue, then add @highfive: assign me to your comment, and I'll assign this to you. 😄

@treiff
Copy link
Contributor

treiff commented Sep 14, 2017

@highfive: assign me

@highfive
Copy link

Hey @treiff! Thanks for your interest in working on this issue. It's now assigned to you!

@fitzgen
Copy link
Member Author

fitzgen commented Sep 14, 2017

@treiff if you run into any questions, don't hesitate to ping me :)

treiff added a commit to treiff/rust-bindgen that referenced this issue Sep 14, 2017
@treiff
Depreciate whitelisted function.
f308fbc 
Closes rust-lang#985
@treiff treiff mentioned this issue Sep 14, 2017
Merged
bors-servo pushed a commit that referenced this issue Sep 14, 2017
Auto merge of #990 - treiff:depreciate-whitelisted-function, r=fitzgen
169adb1 
Depreciate whitelisted function.

Closes #985

I also noticed a reference to `whitelisted_function` within the book, should this be updated as well?

https://github.com/rust-lang-nursery/rust-bindgen/blob/a371de097f5e37eb01754525fb1e2029ca88b0be/book/src/whitelisting.md

I've started to learn rust recently, so please let me know if there is anything I missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy enhancement help wanted I-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @treiff @highfive