Rewrite has_destructor as a fixed point analysis
#927
Comments
6 tasks
|
I would like to take a stab at this. I've taken a look at the comments and the PR in #765, as well as the existing code for the has_destructor analysis, so I feel like I have what I need to get started. |
|
@bd339 great! Let me know if you run into any trouble or have any questions! |
bors-servo
pushed a commit
that referenced
this issue
Aug 25, 2017
Rewrite `has destructor` analysis as a fixed-point analysis Fixes #927 . Note that this creates a dependency between the "cannot derive copy" and "has destructor" analysis, i.e. the "has destructor" analysis must run before the "cannot derive copy" analysis, because "cannot derive copy" needs the results of "has destructor".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Very similar to #765, you could look at the PR that fixed that issue and have a template for fixing this issue.
This will allow us to compute the information once and then cache the results, as well as remove the
detect_has_destructor_cyclefield.I'm happy to mentor anyone who wants to pick this up.
The text was updated successfully, but these errors were encountered: