Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"manually" implement PartialEq when it cannot be derived #879

Closed
fitzgen opened this issue Aug 1, 2017 · 2 comments
Closed

"manually" implement PartialEq when it cannot be derived #879

fitzgen opened this issue Aug 1, 2017 · 2 comments
Labels
A-derive C-assigned E-less-easy enhancement help wanted

Comments

@fitzgen
Copy link
Member

fitzgen commented Aug 1, 2017

Depends on #878.

We should be conservative and only implement this when the reason we cannot derive is because we're hitting the array length derive limit and similar easy cases. We can't know all the corner cases for types we have no knowledge of, and we shouldn't try.
@fitzgen fitzgen mentioned this issue Aug 1, 2017
Open
11 tasks
@pepyakin
Copy link
Contributor

@highfive: assign me

@highfive
Copy link

Hey @pepyakin! Thanks for your interest in working on this issue. It's now assigned to you!

This was referenced Sep 20, 2017
Open
Merged
bors-servo pushed a commit that referenced this issue Oct 2, 2017
Auto merge of #1012 - pepyakin:derive-partialeq-manually, r=fitzgen
48ca92b 
Derive partialeq "manually" when possible

Fixes #879

r? @fitzgen
bors-servo pushed a commit that referenced this issue Oct 2, 2017
Auto merge of #1012 - pepyakin:derive-partialeq-manually, r=fitzgen
4e74c39 
Derive partialeq "manually" when possible

Fixes #879

r? @fitzgen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-derive C-assigned E-less-easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @pepyakin @highfive