-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protected member functions in opaque c++ types #807
Comments
Thanks for the bug report! |
It seems to me that we shouldn't be generating |
Actually, I think it is desired to still generate an opaque types methods (care to confirm @emilio? at least, I know one person who was requesting this feature just yesterday, and I incorrectly told him that we didn't do it, but that it was possible). Will fix the tracing code instead of removing the method bindings. |
This makes tracing opaque types' edges match what we codegen for opaque types. Although we still generate constructors, methods, etc for opaque types (just not fields and base members) we were not tracing them. Fixes rust-lang#807
This makes tracing opaque types' edges match what we codegen for opaque types. Although we still generate constructors, methods, etc for opaque types (just not fields and base members) we were not tracing them. Fixes rust-lang#807
…enerated, r=emilio Fix tracing of opaque types This makes tracing opaque types' edges match what we codegen for opaque types. Although we still generate constructors, methods, etc for opaque types (just not fields and base members) we were not tracing them. Fixes #807 This miiight be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1366050 too. r? @emilio
I stumbled over another issue with protected member functions in opaque types. I am using the latest rust-bindgen ( a00db04 ) to get the benefit of those others bugs you guys fixes so quickly. Thanks again!
Input C/C++ Header
Bindgen Invocation
Actual Results
compilatin with rustc yields:
Expected Results
I would expect all members of the opaque type to not show up in the bindings.
RUST_LOG=bindgen
OutputThe text was updated successfully, but these errors were encountered: