Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite can_derive_debug as either a graph traversal or fix-point analysis #767

Closed
fitzgen opened this issue Jun 19, 2017 · 5 comments
Closed

Comments

@fitzgen
Copy link
Member

fitzgen commented Jun 19, 2017

See #536 for details.

@photoszzt
Copy link
Contributor

While I'm waiting things to compile, I wrote part of this following the skeleton in #765 in photoszzt@9e170ae. I also separate the MonotoFramework to the other file (photoszzt@718d367).

Looking at the skeleton code, I'm not sure where the consider_edge is used.

@fitzgen
Copy link
Member Author

fitzgen commented Jul 7, 2017

@highfive assign @photoszzt

@fitzgen
Copy link
Member Author

fitzgen commented Jul 7, 2017

Hmm, I guess highfive bot doesn't let you assign other people, and I can't assign either. Ah well.

Anyways, cool! :)

The commit separating the analysis infrastructure to its own file can land now, if you want to make a PR with just that commit.

The consider_edge function would be used to filter edges from the IR graph that don't matter for this analysis, and would be called when constructing the reversed graph for dependencies. Did you take a look at its use in the UsedTemplateParams analysis? That should hopefully help clear things up.

Easiest way for me to provide feedback on the CanDeriveDebugAnalysis would be to open a PR so I can leave comments inline easily.

bors-servo pushed a commit that referenced this issue Jul 20, 2017
Use fix point analysis to implement can_derive_debug

It's failing about 30 tests now and most of them is related to template. I'm also not so sure about the place to call compute_can_derive_debug in gen.
Fix: #767

r? @fitzgen
@KiChjang
Copy link
Member

KiChjang commented Jul 21, 2017

FTR, @highfive assign me doesn't actually do anything facy behind the scenes, all it does is add a C-assigned tag to the issue, so if you do want to "assign" an issue to someone else, you can simply put the C-assigned tag on the issue manually.

@fitzgen
Copy link
Member Author

fitzgen commented Jul 21, 2017

FTR, @highfive assign me doesn't actually do anything facy behind the scenes, all it does is add a C-assigned tag to the issue, so if you do want to "assign" an issue to someone else, you can simply put the C-assigned tag on the issue manually.

Huh. It seems the "assigned" field is pretty useless then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants