Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from "whitelist"/"blacklist" terminology #1997

Closed
Manishearth opened this issue Feb 16, 2021 · 2 comments
Closed

Move away from "whitelist"/"blacklist" terminology #1997

Manishearth opened this issue Feb 16, 2021 · 2 comments

Comments

@Manishearth
Copy link
Member

Manishearth commented Feb 16, 2021 •
edited
Loading

Bindgen currently uses "whitelist" and "blacklist" terminology in its flags. The Rust project and the industry in general have been slowly moving off of these due to their negative implications (rust-lang/rust#74150, rust-lang/rust-clippy#5896), perhaps we should do the same here? I think we can keep an alias for backwards compatibility, but document allowlist/denylist instead.
@Manishearth Manishearth changed the title Move away from "whitelist"/"blacklist Move away from "whitelist"/"blacklist" terminology Feb 16, 2021
@emilio
Copy link
Contributor

emilio commented Feb 16, 2021

Dupe of #1812, there's a patch about to land in #1990.

@emilio emilio closed this as completed Feb 16, 2021
@Manishearth
Copy link
Member Author

wow, amazing timing

DoumanAsh added a commit to DoumanAsh/opusic-sys that referenced this issue Apr 23, 2021
@DoumanAsh
Upgrade to bindgen 0.58 with some SJW renaming
855ed79 
Retard issue rust-lang/rust-bindgen#1997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emilio @Manishearth