Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindgen should use the RUSTFMT environment variable if it wasn't set with with_rustfmt #1601

Closed
glandium opened this issue Jul 26, 2019 · 1 comment · Fixed by #1602
Closed

bindgen should use the RUSTFMT environment variable if it wasn't set with with_rustfmt #1601

glandium opened this issue Jul 26, 2019 · 1 comment · Fixed by #1602
Labels
enhancement help wanted

Comments

@glandium
Copy link
Contributor

It seems absurd that every single build script that depends on bindgen and doesn't disable rustfmt has to handle getting the environment variable and use with_rustfmt on its own. The net result is that in Firefox, only stylo uses the RUSTFMT environment variable, and baldrdash, coreaudio-sys and js all ignore it.
@glandium glandium changed the title bindgen should fall back to RUSTFMT if it can't find rustfmt bindgen should use the RUSTFMT environment variable if it wasn't set with with_rustfmt Jul 26, 2019
@emilio
Copy link
Contributor

emilio commented Jul 26, 2019

Sure, that's fair. Should be a pretty easy change.

emilio added a commit to emilio/rust-bindgen that referenced this issue Jul 26, 2019
@emilio
Allow to override rustfmt path with an environment variable.
115b453 
Fixes rust-lang#1601
@emilio emilio mentioned this issue Jul 26, 2019
Merged
emilio added a commit that referenced this issue Jul 26, 2019
@emilio
Allow to override rustfmt path with an environment variable. (#1602)
37fa476 
Also fix rustfmt installation to be via rustup, since rustfmt-nightly doesn't compile in nightly rust.

Fixes #1601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to override rustfmt path with an environment variable. emilio/rust-bindgen
2 participants
@glandium @emilio