Add BINDGEN_EXTRA_CLANG_ARGS env variable #1537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @fitzgen (or someone else) soon. |
emilio
requested changes
Mar 11, 2019
|
I think I have fixed both comments, @emilio. Thanks for catching those issues! |
emilio
reviewed
Mar 13, 2019
emilio
approved these changes
Mar 15, 2019
|
I'd like to get a crates.io version with this change in it. When is the 0.48.2 release? |
|
I'll try to publish something this week :) |
tmfink
added a commit
to tmfink/rust-bindgen
that referenced
this pull request
Jun 5, 2020
Feature was originally introduced in pull-request rust-lang#1537
emilio
pushed a commit
that referenced
this pull request
Jun 5, 2020
Feature was originally introduced in pull-request #1537
This was referenced Jun 22, 2020
Kixunil
pushed a commit
to Kixunil/rust-bindgen
that referenced
this pull request
Nov 3, 2020
Feature was originally introduced in pull-request rust-lang#1537
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to users in #1229 , my cross compiler needed a way to pass
--sysroot <custom chroot path>to all invocations of clang without modifying Rust crate sources. After finding ways to do that with environment variables for the pkgconfig, cmake, and cc crates, I couldn't find one for bindgen. So here it is!While I think it's an important fix for corner cases, I've chosen not to document it since it might be a footgun for new users. If you disagree, I'd happily add a docstring if I could get guidance on where.
Since they commented on #1229:
r? @fitzgen