Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming scheme for whitelisting / blacklisting vs. rustified enum configurations. #1125

Closed
emilio opened this issue Oct 30, 2017 · 0 comments
Closed

Inconsistent naming scheme for whitelisting / blacklisting vs. rustified enum configurations. #1125

emilio opened this issue Oct 30, 2017 · 0 comments
Labels
enhancement help wanted

Comments

@emilio
Copy link
Contributor

emilio commented Oct 30, 2017

The configuration for rustified-enum uses canonical_name. The configuration for whitelisting uses canonical_path.

I think rustified_enum and similar configs should use canonical_path too, since that handles namespaces properly.
emilio added a commit to emilio/servo that referenced this issue Oct 31, 2017
@emilio
style: Update bindgen to 0.31.2.
0a25981 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: EY5eNnCiTIw
emilio added a commit to emilio/servo that referenced this issue Oct 31, 2017
@emilio
style: Update bindgen to 0.31.2.
20606b5 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: EY5eNnCiTIw
emilio added a commit to emilio/servo that referenced this issue Oct 31, 2017
@emilio
style: Update bindgen to 0.31.3.
b721215 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

Bug: 1412486
Reviewed-by: xidorn
MozReview-Commit-ID: EY5eNnCiTIw
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Nov 1, 2017
@emilio
Bug 1412486: Update bindgen. r=xidorn
93dd489 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5

--HG--
extra : rebase_source : 6cda8e65315d97f394ed2441dd882b6ff955efae
Fischer-L pushed a commit to Fischer-L/gecko that referenced this issue Nov 1, 2017
@emilio
Bug 1412486: Update bindgen. r=xidorn
3e8259f 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5
JerryShih pushed a commit to JerryShih/gecko-dev that referenced this issue Nov 2, 2017
@emilio
Bug 1412486: Update bindgen. r=xidorn
633cd51 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5
@emilio emilio mentioned this issue Nov 27, 2017
Open
@tamird tamird mentioned this issue Nov 27, 2017
Merged
bors-servo pushed a commit that referenced this issue Nov 28, 2017
Auto merge of #1162 - tamird:enum-naming-consistency, r=emilio
75f9e1c 
Properly handle namespaces for enum configuration options

...by using canonical_path rather than canonical_name.

Fixes #1125.

r? @emilio
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1412486: Update bindgen. r=xidorn
fe78451 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5

UltraBlame original commit: b21ef5bb00d37e161d618fc0e702a647e445c0f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 2, 2019
@marco-c
Bug 1412486: Update bindgen. r=xidorn
c63ed3f 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5

UltraBlame original commit: b21ef5bb00d37e161d618fc0e702a647e445c0f8
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 2, 2019
@marco-c
Bug 1412486: Update bindgen. r=xidorn
2a454ce 
Constified enums are default now. I think I want to introduce an option to
bindgen to allow setting the default enum behavior, but it doesn't need to block
this.

The ServoBindings.toml changes are somewhat hacky, but that's because of
rust-lang/rust-bindgen#1125.

Also, the fixups now need to account for whitespace, since quote generates stuff
like root :: nsString, and we don't rustfmt the bindings if there's no rustfmt
installed.

MozReview-Commit-ID: FZOvZnfYXj5

UltraBlame original commit: b21ef5bb00d37e161d618fc0e702a647e445c0f8
@johnmave126 johnmave126 mentioned this issue Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emilio