Completion item details #9891
Completion item details #9891
Conversation
|
Currently depends on my fork of |
|
It may be cool to do something like remove the fn signature from the label and put it into the |
| @@ -15,4 +15,5 @@ pub struct CompletionConfig { | |||
| pub add_call_argument_snippets: bool, | |||
| pub snippet_cap: Option<SnippetCap>, | |||
| pub insert_use: InsertUseConfig, | |||
| pub label_details: bool, | |||
There was a problem hiding this comment.
It feels like this is strictly LSP-specific, and affects only how we convert ide::CompletionItem to lsp_types::CompletionItem. So, this setting should only exist in the rust-analyzer crate.
There was a problem hiding this comment.
I'm not so sure. For instance: if the client supports label details and we have on the fly imports enabled it may make sense to move the (use import::path) out of the label and render it as part of the CompletionItemLabelDetails. We would do something similar for (as Trait)
|
triage: this could switch to the upstream lsp-types. |
|
Yes. I haven't had a chance to finish this yet. |
|
Are there any updates on this? |
Add simple support for completion item details Supercedes #9891 This doesn't yet really implement anything new, it just adds the scaffolding for the protocol conversion
|
In order to clean up stale PRs I updated the basic parts of this and opened #12807 with that |
Implement basic CompletionItemLabelDetails support.
Fixes #7565