Move CI to rust-cache Action#8427
Conversation
| pub(crate) fn run(self) -> Result<()> { | ||
| let slow_tests_cookie = Path::new("./target/.slow_tests_cookie"); | ||
| if !slow_tests_cookie.exists() { | ||
| panic!("slow tests were skipped on CI!") |
There was a problem hiding this comment.
I wonder if it's worth keeping this check.
There was a problem hiding this comment.
https://github.com/rust-analyzer/rust-analyzer/blob/fc9eed4836dfc88fe2893c81b015ab440cea2ba6/crates/test_utils/src/lib.rs#L285
so essentially check that CI really defines the CI env var?
There was a problem hiding this comment.
Yeah, it's a check to make sure we set those two variables. We could test them in the workflow, but it badly needs a refactoring (I know it's possible to remove the duplication, but I don't know the syntax).
There was a problem hiding this comment.
🤔 I guess we can just remove this. If, at some point we notice that slow tests are not being run, we'll learn that the check was helpful in the end :)
|
Pinned the action to Swatinem/rust-cache@ce325b6 The |
|
Assigning @lnicola to make a judgement call here :-) |
|
Ok, let's just land it -- we can always go back if we want! bors r+ |
|
Yeah, sorry for letting this slip. LGTM. |
|
@Swatinem I don't think we've had any caching issues after the PR, so I guess it's working :-). |
|
Thats very good to hear. Also thanks @matklad for mentioning the action, the number of likes has exploded since your blog post :-D |
3 participants
This is humbling. I actually took inspiration from RAs pre-cache xtask when developing my action ;-)
Closes #7731