Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive completion #7644

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Primitive completion #7644

merged 2 commits into from
Feb 12, 2021

Conversation

jonas-schievink
Copy link
Contributor

Fixes #7642

@matklad
Copy link
Member

matklad commented Feb 11, 2021

r=me

@jonas-schievink
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request Feb 12, 2021
7644: Primitive completion r=jonas-schievink a=jonas-schievink

Fixes #7642

7648: fix nightly warning `legacy_derive_helpers` r=jonas-schievink a=peddermaster2

With a recent nightly (e.g. 2021-02-10) a warning comes up. This PR reorders the attributes to fix the warning.

See rust-lang/rust#79202

Co-authored-by: Jonas Schievink <[email protected]>
Co-authored-by: Peter Wischer <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 12, 2021

Build failed (retrying...):

bors bot added a commit that referenced this pull request Feb 12, 2021
7644: Primitive completion r=jonas-schievink a=jonas-schievink

Fixes #7642

Co-authored-by: Jonas Schievink <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 12, 2021

Timed out.

@jonas-schievink
Copy link
Contributor Author

what "timed out" here?

@jonas-schievink
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 12, 2021

@bors bors bot merged commit dee5aba into rust-lang:master Feb 12, 2021
@jonas-schievink jonas-schievink deleted the primitive-completion branch February 15, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no auto-completion for associated constants/functions on primitive types
3 participants