Skip to content

Reduce duplication in fixtures #6123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 4 commits into from
Oct 2, 2020
Merged

Reduce duplication in fixtures #6123

bors merged 4 commits into from
Oct 2, 2020

Conversation

@matklad
Copy link
Contributor

@matklad matklad commented Oct 2, 2020

bors r+
🤖

matklad added 4 commits October 2, 2020 16:45
@matklad
Move ide::AnalysisChange -> base_db::Change
8716c4c 
This seems like a better factoring logically; ideally, clients shouldn't touch
`set_` methods of the database directly. Additionally, I think this
should remove the unfortunate duplication in fixture code.
@matklad
Rewrite fixtures on top of Change
eeb27f9
@matklad
Get rid of MockAnalysis
09348b2
@matklad
rename mock_analysis -> fixture
b062596
@matklad matklad mentioned this pull request Oct 2, 2020
Merged
@bors
Copy link
Contributor

bors bot commented Oct 2, 2020

Build succeeded:

@bors bors bot merged commit 673e1dd into rust-lang:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matklad @lnicola